[torqueusers] patch for tclx8.4

Garrick Staples garrick at usc.edu
Sun Mar 5 01:23:48 MST 2006


On Sat, Mar 04, 2006 at 01:47:44PM -0800, Martin Siegert alleged:
> Hi,
> 
> attached is a patch intended to make torque work with tclx version 8.4
> when configured with
> 
> --enable-gui --with-tclx
> 
> This has been tested on SLES 9 on powerpc64 with tclx 8.4 and on RH 7.3
> on i686 with tclx 8.3.
> 
> [some of the changes in configure are just changes to white space:
> in order to analyze the configure script I changed the somewhat random
> indentation in configure to a more regular pattern.]

Can you submit again without the white space changes?  There's not much
point in patching configure because it is supposed to be a generated
files.  Also, 2.1.0 has an entirely new build system now.


> --- torque-2.0.0p8/src/tools/pbsTkInit.c.orig	2006-01-27 10:42:05.000000000 -0800
> +++ torque-2.0.0p8/src/tools/pbsTkInit.c	2006-03-04 10:36:46.906960773 -0800
> @@ -120,9 +120,11 @@
>  #if	TCLX
>  	if (Tclx_Init(interp) == TCL_ERROR)
>  		return TCL_ERROR;
> +#if !defined(CONST84)
>  	if (Tkx_Init(interp) == TCL_ERROR)
>  		return TCL_ERROR;
>  #endif
> +#endif

Can you explain this change?  Does 8.4 not have a working tkx?  Why use
--with-tclx if you are #ifdef'ing out the tkx support?  Just use
--without-tclx if you don't want it?

Other then testing for lib64 on ppc64, what is the specific problem that
is being solved?

-- 
Garrick Staples, Linux/HPCC Administrator
University of Southern California
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.supercluster.org/pipermail/torqueusers/attachments/20060305/2d2db147/attachment.bin


More information about the torqueusers mailing list