[torqueusers] Job names starting with a numeric character

Garrick Staples garrick at usc.edu
Thu Aug 11 19:35:05 MDT 2005


On Thu, Aug 11, 2005 at 08:09:33PM -0400, Daniel Widyono alleged:
> >   Thanks for the recommended patch!
> 
> Just confirming: which is your expected recommended patch?  Changing to
> isalnum or changing arg to 0?

If it's the later, don't forget that it's called in 2 other places:

src]$ grep -r check_job_name .
./gui/Ccode/xpbs_scriptload.c:              if (check_job_name(optarg, 1) == 0) {
./cmds/qalter.c:        if (check_job_name(optarg, 1) == 0) {
./cmds/qsub.c:          if (check_job_name(optarg,1) == 0) 
./cmds/qsub.c:        if (check_job_name(basename,0) == 0) 

I'd imagine the cleanest way is to change the args in the client commands but
wrapped in PBS_NO_POSIX_VIOLATION blocks.

 
> > > Change the arg "1" to check_job_name() to "0".
> 
> > > Alternatively patch the checking function directly:
> > > torque/src/lib/Libcmds/ck_job_name.c, function check_job_name().
> > > It is the isalpha() call.
> _______________________________________________
> torqueusers mailing list
> torqueusers at supercluster.org
> http://www.supercluster.org/mailman/listinfo/torqueusers

-- 
Garrick Staples, Linux/HPCC Administrator
University of Southern California
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.supercluster.org/pipermail/torqueusers/attachments/20050811/10cfb8cd/attachment.bin


More information about the torqueusers mailing list