[torqueusers] Re: mom segfault in new diag code

[Dave Jackson]

Garrick,

  While most recent p4 snapshots fixed the tmpLine/output overflows,
only the most recent corrects the tlist() issue.  Thanks for reporting
this and please let us know if things work better.

Dave

On Wed, 2004-10-27 at 19:52, Garrick Staples wrote:
> Actually, tlist() seems to be overflowing the buffer too.
> 
> On Wed, Oct 27, 2004 at 04:33:35PM -0700, Garrick Staples alleged:
> > 
> > torque-1.1.0p4-snap.1098121584
> > 
> > The new momctl diag code is segfaulting in mom_main.c:rm_request().  It seems
> > that neither tmpLine or output are large enough.  Specifically the second
> > strcat in this code is overflowing output:
> > 
> >             if (verbositylevel >= 1)
> >               {
> >               /* display okclient list */
> >               
> >               tmpLine[0] = '\0';
> >                 
> >               tlist(okclients,tmpLine,1024);
> >               
> >               strcat(output,"Trusted Client List:   ");
> >               
> >               strcat(output,tmpLine);
> >               
> >               strcat(output,"\n");
> >               }
> > 
> > 
> > -- 
> > Garrick Staples, Linux/HPCC Administrator
> > University of Southern California
> 
>