[torquedev] [Bug 207] New: qsub segfault if malformed environment

[bugzilla-daemon at supercluster.org]

http://www.clusterresources.com/bugzilla/show_bug.cgi?id=207

           Summary: qsub segfault if malformed environment
           Product: TORQUE
           Version: 4.0.*
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P5
         Component: clients
        AssignedTo: knielson at adaptivecomputing.com
        ReportedBy: ezellma at ornl.gov
                CC: torquedev at supercluster.org
   Estimated Hours: 0.0


This was found in 4.1-fixes, but that's not a valid target in Bugzilla.

I've been having occasional segfaults when Moab is trying to 'qsub' a job as
the user.  Loading the core file in GDB, it appears that envp has strings that
don't contain an '=' sign.  This should never happen, but Moab is using
something like execve to manually set the environment.  I'm going to file a bug
with the Moab guys, but TORQUE should protect itself from this situation.

The attached patch simply ignores environment strings that don't have an '='
sign.  It compiles clean, but I haven't had a chance to fully test it yet. I
set the this situation to return PBSE_BAD_PARAMETER. Not sure if that's the
best code here, but it doesn't look like any calling functions actually use the
return code.

-- 
Configure bugmail: http://www.clusterresources.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.