[torquedev] DBPRT statements and #ifdef 0

Glen Beane glen.beane at gmail.com
Tue Mar 29 20:33:35 MDT 2011


2011/3/15 "Mgr. Šimon Tóth" <toth at fi.muni.cz>

> > Someone mentioned a while back removing the DBPRT statements from TORQUE.
> We are considering removing these statements for TORQUE 4.0. Of course, we
> would like to know if these statements are still useful to anyone or are
> used by anyone? If the answers to these questions are no and no, can anyone
> think of another reason why these should stay in the code?
> >
> > Additionally, one of the developers pointed out the existence of code
> segments wrapped by #if 0 (see start_exec.c for examples). Most of these
> haven't been changed for about two years. Obviously, before anything can be
> deleted it has to be inspected and considered in context, but does anyone
> have objections to moving towards removing this code? Would anyone volunteer
> to inspect some of the code to see if it has any value or a reason to keep
> it?
> >
> > I suppose there are two ways you can approach this problem:
> >
> > 1. There is no reason to keep extra clutter in the code that just makes
> it harder to understand.
> > 2. There is no real benefit other than aesthetic for deleting code, and
> there is a risk of losing information when some code is deleted.
> >
> > What are your thoughts?
>
> Some of the DBPRT should be probably converted into standard logs (debug
> level).
>

I agree.

While we're looking at loggin I also think TORQUE is guilty of some
excessive logging in some cases (is it really necessary to print the version
every 30 seconds or so)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.supercluster.org/pipermail/torquedev/attachments/20110329/9faab1b3/attachment.html 


More information about the torquedev mailing list