[torquedev] DBPRT statements and #ifdef 0

Glen Beane glen.beane at gmail.com
Tue Mar 29 20:32:25 MDT 2011


On Tue, Mar 15, 2011 at 5:23 PM, David Beer <dbeer at adaptivecomputing.com>wrote:

> Hi all,
>
> Someone mentioned a while back removing the DBPRT statements from TORQUE.
> We are considering removing these statements for TORQUE 4.0. Of course, we
> would like to know if these statements are still useful to anyone or are
> used by anyone? If the answers to these questions are no and no, can anyone
> think of another reason why these should stay in the code?
>
> Additionally, one of the developers pointed out the existence of code
> segments wrapped by #if 0 (see start_exec.c for examples). Most of these
> haven't been changed for about two years. Obviously, before anything can be
> deleted it has to be inspected and considered in context, but does anyone
> have objections to moving towards removing this code? Would anyone volunteer
> to inspect some of the code to see if it has any value or a reason to keep
> it?
>
> I suppose there are two ways you can approach this problem:
>
> 1. There is no reason to keep extra clutter in the code that just makes it
> harder to understand.
> 2. There is no real benefit other than aesthetic for deleting code, and
> there is a risk of losing information when some code is deleted.
>
> What are your thoughts?
>

my vote is to remove #if 0 blocks

they make the code hard to read, and the code in those blocks does not get
maintained and becomes irrelevant anyway

this is one of the reasons we use svn,  so we don't have to do ugly things
like this - the information isn't really lost
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.supercluster.org/pipermail/torquedev/attachments/20110329/301392e5/attachment.html 


More information about the torquedev mailing list