[torquedev] [Bug 134] New: Attribute setting is broken for += and -= (all versions affected)

[bugzilla-daemon at supercluster.org]

http://www.clusterresources.com/bugzilla/show_bug.cgi?id=134

           Summary: Attribute setting is broken for += and -= (all
                    versions affected)
           Product: TORQUE
           Version: 2.4.x
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: libtorque
        AssignedTo: dbeer at adaptivecomputing.com
        ReportedBy: SimonT at mail.muni.cz
                CC: torquedev at supercluster.org
   Estimated Hours: 0.0


The following code needs to be changed in src/lib/Libattr/attr_atomic.c

    /* duplicate current value, if set AND not already dup-ed */

    if (((old + index)->at_flags & ATR_VFLAG_SET) &&
        !((new + index)->at_flags & ATR_VFLAG_SET))
      {
      if ((rc = (pdef + index)->at_set(new + index, old + index, SET)) != 0)
        break;

In the attr_atomic_set function the original call was:
(pdef + index)->at_set(new + index, old + index, plist->al_atopl.op)

That is of course wrong, since it won't duplicate the value unless, the
operation is SET.

-- 
Configure bugmail: http://www.clusterresources.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.