[torquedev] Release Candidate for TORQUE 2.5.8

Christopher Samuel samuel at unimelb.edu.au
Mon Aug 22 21:17:46 MDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 23/08/11 13:03, Glen Beane wrote:

> -Werror and -pedantic used to be default and they needed to explicitly
> disabled with --disable-gcc-warnings.  I haven't built a real recent
> version of TORQUE (been away from the project for a while), but from
> what it sounds that this is no longer true and you need to explicitly
> enable -Werror.

It appears that it might have crept in with SVN revision
4385 (git hash 798b12e822079126abce273c3f43dd39a2c7faa7 for
those using a git svn clone like me).

I don't guarantee this conclusion to be correct - my autotools
foo is very weak..


commit 798b12e822079126abce273c3f43dd39a2c7faa7
Author: knielson <knielson at 8f940c70-5916-0410-ac46-d1fa2fa6ea29>
Date:   Thu Dec 23 17:01:10 2010 +0000

    put spec file changes back into the build.
    
    git-svn-id: svn://svn.clusterresources.com/torque@4385 8f940c70-5916-0410-ac46-d1fa2fa

diff --git a/branches/2.5-fixes/buildutils/torque.spec.in b/branches/2.5-fixes/buildutils/
index 2894e0f..b8dc41d 100644
- --- a/branches/2.5-fixes/buildutils/torque.spec.in
+++ b/branches/2.5-fixes/buildutils/torque.spec.in

[...]
diff --git a/branches/2.5-fixes/configure.ac b/branches/2.5-fixes/configure.ac
index d1e846c..218a865 100644
- --- a/branches/2.5-fixes/configure.ac
+++ b/branches/2.5-fixes/configure.ac
@@ -290,9 +290,7 @@ AC_ARG_ENABLE(gcc_warnings, [
                           gcc, default is to error on any warning])
 if test "x$GCC" = "xyes" ;then
   AC_MSG_CHECKING([whether to use strict gcc warnings])
- -  if test "${enable_gcc_warnings}" == "no" ; then
- -    AC_MSG_RESULT([no])
- -  else
+  if test "${enable_gcc_warnings}" == "yes" ; then
     if test "x$build_drmaa" = "xyes" ;then
       AC_MSG_RESULT([no... because DRMAA is being built])
     else
@@ -300,6 +298,8 @@ if test "x$GCC" = "xyes" ;then
       AX_CFLAGS_GCC_OPTION([-W -Wall -Wno-unused-parameter -Wno-long-long -pedantic -Werr
       gccwarnings=yes
     fi
+  else
+    AC_MSG_RESULT([no])
   fi
 fi


> We went through great pains to get torque to build without warnings --
> especially Garrick (he did a lot of the work to remove warnings).  I 
> would like to keep it warning free.

Agreed - you should see what happens when you build it
with clang (the C frontend for LLVM)..

cheers,
Chris
- -- 
    Christopher Samuel - Senior Systems Administrator
 VLSCI - Victorian Life Sciences Computation Initiative
 Email: samuel at unimelb.edu.au Phone: +61 (0)3 903 55545
         http://www.vlsci.unimelb.edu.au/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5TG9oACgkQO2KABBYQAh8LmQCgivHpCup7cVLYAefHlls82fVn
O/YAoI1/vm2h7wzf4IEZo2ClBO+AuB4h
=pUGK
-----END PGP SIGNATURE-----


More information about the torquedev mailing list