[torquedev] [Bug 82] New: Unnecessary code in send_job

bugzilla-daemon at supercluster.org bugzilla-daemon at supercluster.org
Wed Sep 22 06:30:21 MDT 2010


http://www.clusterresources.com/bugzilla/show_bug.cgi?id=82

           Summary: Unnecessary code in send_job
           Product: TORQUE
           Version: 2.4.x
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: pbs_server
        AssignedTo: glen.beane at gmail.com
        ReportedBy: SimonT at mail.muni.cz
                CC: torquedev at supercluster.org
   Estimated Hours: 0.0


This can and probably should be removed:

if (move_type != MOVE_TYPE_Exec) /* not if sending to MOM */
  job_purge(jobp);


This is a forked child and therefore it doesn't matter at all if the job gets
purged. The process ends after few lines anyway.

Plus the job variable is being accessed in error handling for PBSD_commit.

-- 
Configure bugmail: http://www.clusterresources.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the torquedev mailing list