[torquedev] read_nonblocking_socket() wtf?
garrick at usc.edu
Fri Jul 16 14:46:23 MDT 2010
On Fri, Jul 16, 2010 at 02:42:42PM -0600, David Beer alleged:
> > I'm on 2.1.x. Is this all fixed up in later branches?
> I'm assuming you're referring to the second fcntl command. It is not fixed in later implementations. Is this the patch you applied?
> Index: src/lib/Libifl/nonblock.c
> --- src/lib/Libifl/nonblock.c (revision 3865)
> +++ src/lib/Libifl/nonblock.c (working copy)
> @@ -99,12 +99,10 @@
> /* the below non-blocking socket flag check should be rolled into
> pbs_disconnect and removed from here (NYI) */
> - /*
> if (fcntl(fd,F_SETFL,flags) == -1)
> - */
> } /* END else (flags & BLOCK) */
> /* Set a timer to prevent an infinite loop here. */
Yes, that's the one, and no, I haven't uncommented it.
Who knows what will break? Someone commented it out for a reason. We've been
using that broken read all over torque for years.
Garrick Staples, GNU/Linux HPCC SysAdmin
University of Southern California
Life is Good!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://www.supercluster.org/pipermail/torquedev/attachments/20100716/89252c41/attachment.bin
More information about the torquedev