[torquedev] [Bug 51] Fix for r3466 commit

bugzilla-daemon at supercluster.org bugzilla-daemon at supercluster.org
Mon Feb 22 13:52:48 MST 2010


http://www.clusterresources.com/bugzilla/show_bug.cgi?id=51

--- Comment #3 from dbeer at adaptivecomputing.com 2010-02-22 13:52:48 MST ---
Simon,

There's one consideration I want to talk to you about before commiting a patch:

Your patch changes things so that the get_correct_jobname function isn't called
if the settings haven't been changed. My only concern is that if a user sets
this, runs a job, and then unsets it, that job may hang in a running state
forever because the server won't always recognize the job's name in the obit.

For me, this is potentially acceptable, it just needs to be considered. We can
instruct people that these settings cannot be changed while jobs are queued or
running. I don't think this would inconvenience anyone much as these settings
shouldn't need to be changed very often, and since most users (I'm guessing)
aren't going to use this feature, and this would affect people that aren't
using it less.

At the same time, this isn't going to add much time to job lookup, since job
lookup has to scroll through all of the jobs known to that server, and this
just adds a function call and some checking. I'm open to both possibilities.
Please let me know your thoughts.

-- 
Configure bugmail: http://www.clusterresources.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the torquedev mailing list