[torquedev] Latest patch in 2.4-fixes

Simon Toth SimonT at mail.muni.cz
Mon Feb 22 03:31:59 MST 2010


I'm confused about the latest patch in 2.4-fixes.

Does the get_correct_jobname() take into account jobs from other
servers? Looking at the code, I would assume that it doesn't.

The whole patch doesn't seem to work. On default, job id's are kept in
their full form id.server.hostname but get_correct_jobname() returns
only id.server

Plus I found a off by one bug:

    /* check for the server suffix */
    if (second_suffix != NULL)
      {
      int len;
      /* dot is still at the second '.' */
      *dot = '\0';
      len = strlen(jobid);

      correct = malloc(len);

      if (correct == NULL)
        {
        log_err(-1,id,"ERROR:    Fatal - Cannot allocate memory\n");
        return(NULL);
        }

      snprintf(correct,len,"%s",jobid);
      *dot = '.';
      }

Should be: len = strlen(jobid)+1;

-- 
Mgr. Simon Toth

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3366 bytes
Desc: S/MIME Cryptographic Signature
Url : http://www.supercluster.org/pipermail/torquedev/attachments/20100222/ed25c42a/attachment.bin 


More information about the torquedev mailing list