[torquedev] Cygwin patch and generic Code Quality

Garrick Staples garrick at usc.edu
Tue Nov 3 08:53:32 MST 2009


Submit a patch.

On Nov 3, 2009, at 6:26 AM, Mgr. Šimon Tóth wrote:

> This is just a generic request for higher Code Quality.
>
> The cygwin patch introduces new function IAmAdmin(), but instead of
> creating two version of this function (one for cygwin and one for
> generic POSIX) it splits the code on many places using #ifdefs.
>
> This approach makes the code hard to read, exponentially increases the
> probability of bugs and also makes the bugs much harder to find and  
> debug.
>
> Plus, please, stop using the K&R backward compatibility macros, the  
> code
> won't compile in K&R anyway, plus current compilers usually have good
> support for both ANSI (C90) and C99 standards, so there is no point  
> for
> this any more.
>
> -- 
> Mgr. Šimon Tóth
> _______________________________________________
> torquedev mailing list
> torquedev at supercluster.org
> http://www.supercluster.org/mailman/listinfo/torquedev



More information about the torquedev mailing list