[torquedev] Cygwin patch and generic Code Quality

"Mgr. Šimon Tóth" SimonT at mail.muni.cz
Tue Nov 3 07:26:39 MST 2009

This is just a generic request for higher Code Quality.

The cygwin patch introduces new function IAmAdmin(), but instead of
creating two version of this function (one for cygwin and one for
generic POSIX) it splits the code on many places using #ifdefs.

This approach makes the code hard to read, exponentially increases the
probability of bugs and also makes the bugs much harder to find and debug.

Plus, please, stop using the K&R backward compatibility macros, the code
won't compile in K&R anyway, plus current compilers usually have good
support for both ANSI (C90) and C99 standards, so there is no point for
this any more.

Mgr. Šimon Tóth

More information about the torquedev mailing list