[torquedev] Compatibility of the libtorque.so

[Garrick Staples]

On Mon, Oct 20, 2008 at 03:22:13PM -0700, Garrick Staples alleged:
> On Mon, Oct 20, 2008 at 04:10:48PM -0600, Josh Butikofer alleged:
> > Everyone,
> > 
> > A quick question for the community developers:
> > 
> > When TORQUE 2.x was released, the library libtorque.so was also 
> > re-versioned to 2.0. I've been told that this was done because the new 
> > library broke compatibility with the old one. There doesn't appear to be 
> > any more information on this in the mailing list or written down 
> > anywhere else. No one here at CRI really remembers why this happened.
> > 
> > Does anyone in the community know if the new libtorque.so library really 
> > does break compatibility? If so, does anyone remember what changed 
> > exactly to break compatibility (or at least made the community afraid 
> > that it would break compatibility)?
> > 
> > Garrick, do you have any more info on this?
> 
> I don't remember the specifics of the change.  I remember doing it because of
> something that Dave changed.

Probably these:

Index: src/include/net_connect.h
===================================================================
--- src/include/net_connect.h   (revision 1302)
+++ src/include/net_connect.h   (revision 1310)
@@ -141,7 +141,7 @@
 
 void add_conn A_((int,enum conn_type,pbs_net_t,unsigned int,void (*func) A_((int))));
 int  find_conn A_((pbs_net_t));
-int  client_to_svr A_((pbs_net_t,unsigned int,int));
+int  client_to_svr A_((pbs_net_t,unsigned int,int,char *));
 void close_conn A_((int));
 pbs_net_t get_connectaddr A_((int));
 int  get_connecthost A_((int sock,char *,int));

Index: src/resmom/catch_child.c
===================================================================
--- src/resmom/catch_child.c    (revision 1302)
+++ src/resmom/catch_child.c    (revision 1310)
@@ -679,7 +679,7 @@
     else
       port = default_server_port;

-    sock = client_to_svr(pjob->ji_qs.ji_un.ji_momt.ji_svraddr,port,1);
+    sock = client_to_svr(pjob->ji_qs.ji_un.ji_momt.ji_svraddr,port,1,NULL);

     if (sock < 0)
       {

Index: src/lib/Libnet/net_client.c
===================================================================
--- src/lib/Libnet/net_client.c (revision 1302)
+++ src/lib/Libnet/net_client.c (revision 1310)
@@ -168,19 +168,27 @@
 
   pbs_net_t     hostaddr,      /* I - internet addr of host */
   unsigned int  port,          /* I - port to which to connect */
-  int           local_port)    /* I - BOOLEAN:  not 0 if use local reserved port */
+  int           local_port,    /* I - BOOLEAN:  not 0 if use local reserved port */
+  char         *EMsg)           /* O (optional,minsize=1024) */


-- 
Garrick Staples, GNU/Linux HPCC SysAdmin
University of Southern California

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.supercluster.org/pipermail/torquedev/attachments/20081020/81464cee/attachment.bin