[torquedev] qalter with blank walltimes sets walltime to zero

Chris Samuel csamuel at vpac.org
Wed Jun 18 07:45:46 MDT 2008


Hi all,

We've found recently that if you happen to do:

qalter -l walltime= 12:0:0 12345

to set job 12345 to now be 12 hours, the job dies
immediately and you get an error about an illegal
job id.

This is because the space results in the walltime of
12345 being set to 0:0:0 and it immediately gets killed
by pbs_mom (quite understandably).

I can't see any reason why setting the walltime to 0
should be valid, but digging around in the code it looks
like decode_time() in src/lib/Libattr/attr_fn_time.c
specifically accepts that as valid and sets the time to 0.

Unfortunately replacing that with a goto to the badval
label results in pbs_server dieing with:

*** glibc detected *** /usr/local/torque-trunk/sbin/pbs_server: double free or corruption (out): 0x00000000023356d0 ***

:-(

My only concern is that blanket banning walltimes of 0
may break the default case where the queues don't set a
default walltime and neither does the job.

Thoughts ?

cheers,
Chris
-- 
Christopher Samuel - (03) 9925 4751 - Systems Manager
 The Victorian Partnership for Advanced Computing
 P.O. Box 201, Carlton South, VIC 3053, Australia
VPAC is a not-for-profit Registered Research Agency


More information about the torquedev mailing list