[torquedev] Patches to torque-2.1.8

Jeffrey B. Reed jeff.reed at intrinsity.com
Wed Jun 27 15:20:34 MDT 2007


We found two issues with torque-2.1.8.

o The qstat -q queue field sizes were not large enough for our configuration
o We found a memory leak in the fifo scheduler.

Please consider applying these patches on the next release.


Jeff
-- 

Jeffrey B. Reed
jbreed at intrinsity.com
512-421-2219

-------------- next part --------------
--- torque-2.1.8/src/scheduler.cc/samples/fifo/check.c~ 2006-10-13 13:25:36.000000000 -0500
+++ torque-2.1.8/src/scheduler.cc/samples/fifo/check.c  2007-05-25 13:37:36.000000000 -0500
@@ -490,12 +490,14 @@
     tmp = node_str;
     if( (rc = pbs_rescquery(pbs_sd, &tmp, 1, &av, &al, &res, &down)) != 0 )
     {
+      free(node_str);
       sprintf(errbuf, "pbs_resquery error: %d", rc);
       sched_log(PBSEVENT_SYSTEM, PBS_EVENTCLASS_NODE, jinfo -> name, errbuf );
       return SCHD_ERROR;
     }
     else
     {
+      free(node_str);
       /* the requested nodes will never be available */
       if( av < 0 )
         jinfo -> can_never_run = 1;

-------------- next part --------------
--- torque-2.1.8/src/cmds/qstat.c~	2007-02-14 10:23:09.000000000 -0600
+++ torque-2.1.8/src/cmds/qstat.c	2007-05-25 16:45:25.000000000 -0500
@@ -819,8 +819,8 @@
   struct attrl *pat;
 
   printf("\nserver: %s\n\n", serv);
-  printf("Queue            Memory CPU Time Walltime Node  Run Que Lm  State\n");
-  printf("---------------- ------ -------- -------- ----  --- --- --  -----\n");
+  printf("Queue            Memory CPU Time Walltime Node    Run   Que   Lm  State\n");
+  printf("---------------- ------ -------- -------- ----  ----- ----- ----  -----\n");
 
   while (pstat != NULL) 
     {
@@ -833,7 +833,7 @@
     nodect= "-- ";
     jrun  = 0;
     jque  = 0;
-    jmax  = blank;
+    jmax  = "  -- ";
 
     pat = pstat->attribs;
 
@@ -877,14 +877,14 @@
 
 		printf("%-16.16s %6.6s %8.8s %8.8s %5.5s ",
 		       pstat->name, rmem, cput, wallt, nodect);
-		printf("%3d %3d %2.2s   %c %c\n",
+		printf("%5d %5d %4.4s   %c %c\n",
 		       jrun, jque, jmax, qenabled, qstarted);
 
 		pstat = pstat->next;
 	}
 
-  printf("                                               ----- -----\n");
-  printf("                                               %5d %5d\n", 
+  printf("                                                ----- -----\n");
+  printf("                                                %5d %5d\n", 
     tot_jrun, 
     tot_jque);
 



More information about the torquedev mailing list