[torquedev] clearing exec_host on job requeue

Åke Sandgren ake.sandgren at hpc2n.umu.se
Sat Feb 17 01:37:59 MST 2007


On Fri, 2007-02-16 at 18:49 -0700, Garrick Staples wrote:
> On Wed, Feb 14, 2007 at 06:52:43PM -0700, Garrick Staples alleged:
> > CRI has a trouble ticket open about a job's exec_host not being cleared
> > when it is requeued.  Apperently this annoys some sysadmins and breaks
> > some 3rd party things like clumon.
> > 
> > I think I just found a bug that pre-dates TORQUE and is fixed with a
> > single character patch!  I need others to look at this and tell me I'm
> > not crazy.
> > 
> > I've already committed it to trunk, but this is trivial for 2.1 as well.
> > 
> > $ svn diff -r1242:1243 src/server/req_jobobit.c 
> > Index: src/server/req_jobobit.c
> > ===================================================================
> > --- src/server/req_jobobit.c    (revision 1242)
> > +++ src/server/req_jobobit.c    (revision 1243)
> > @@ -1419,7 +1419,7 @@
> >  
> >        /* Now re-queue the job */
> >  
> > -      if ((pjob->ji_qs.ji_svrflags | JOB_SVFLG_HOTSTART) == 0) 
> > +      if ((pjob->ji_qs.ji_svrflags & JOB_SVFLG_HOTSTART) == 0) 
> >          {
> >          /* in case of server shutdown, don't clear exec_host */
> >          /* will use it on hotstart when next comes up       */
> 
> I'm also adding an at_free() call there for session_id.
> 
>          job_attr_def[(int)JOB_ATR_exec_host].at_free(
>            &pjob->ji_wattr[(int)JOB_ATR_exec_host]);
> +
> +        job_attr_def[(int)JOB_ATR_session_id].at_free(
> +          &pjob->ji_wattr[(int)JOB_ATR_session_id]);
>          }
>        
> 
> Anyone opposed for these 2 changes for 2.1-fixes?  IMHO, it should go
> in.  But since this is a behaviour change, I want to ask first.

I'm all for.

-- 
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: ake at hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90 7866126
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se



More information about the torquedev mailing list