[torquedev] clearing exec_host on job requeue
garrick at clusterresources.com
Fri Feb 16 18:49:49 MST 2007
On Wed, Feb 14, 2007 at 06:52:43PM -0700, Garrick Staples alleged:
> CRI has a trouble ticket open about a job's exec_host not being cleared
> when it is requeued. Apperently this annoys some sysadmins and breaks
> some 3rd party things like clumon.
> I think I just found a bug that pre-dates TORQUE and is fixed with a
> single character patch! I need others to look at this and tell me I'm
> not crazy.
> I've already committed it to trunk, but this is trivial for 2.1 as well.
> $ svn diff -r1242:1243 src/server/req_jobobit.c
> Index: src/server/req_jobobit.c
> --- src/server/req_jobobit.c (revision 1242)
> +++ src/server/req_jobobit.c (revision 1243)
> @@ -1419,7 +1419,7 @@
> /* Now re-queue the job */
> - if ((pjob->ji_qs.ji_svrflags | JOB_SVFLG_HOTSTART) == 0)
> + if ((pjob->ji_qs.ji_svrflags & JOB_SVFLG_HOTSTART) == 0)
> /* in case of server shutdown, don't clear exec_host */
> /* will use it on hotstart when next comes up */
I'm also adding an at_free() call there for session_id.
Anyone opposed for these 2 changes for 2.1-fixes? IMHO, it should go
in. But since this is a behaviour change, I want to ask first.
More information about the torquedev