[torquedev] Re: PBatchReqType[]

Garrick Staples garrick at clusterresources.com
Tue Feb 13 13:23:15 MST 2007


On Tue, Feb 13, 2007 at 08:32:19PM +0100, Sergio Gelato alleged:
> * torquedev-request at supercluster.org [2007-02-13 12:00:03 -0700]:
> > From: "Glen Beane" <glen.beane at gmail.com>
> [...] 
> > How would you like to be recognized in the CHANGELOG?  We usually give
> > credit to organizations that submit patches.
> 
> My employer, Stockholm University, may be mentioned in this context.
> 
> > From: Garrick Staples <garrick at clusterresources.com>
>  
> > It looks like an ABI and API change.  We'd have to bump libtorque.so's version.
> > 
> > Anyone know of a client that directly references PBatchReqType[]?
> 
> I suppose one could leave out the "static" keyword in that case.
> 
> Note, however, that PBatchReqType[] isn't declared in any header file,
> so it's questionable whether it belongs to the public API.

It shouldn't be part of the public API, because req types are never
exposed to clients.

 
> Non-API/ABI-changing alternatives to my implementation are of course
> possible, but may be more error-prone in the long run.

We obviously don't want to change things in 2.1, so we should just add
the bounds checking in pbs_server.

We can change it for 2.2.



More information about the torquedev mailing list