[torquedev] queue naming restrictions?

Garrick Staples garrick at clusterresources.com
Wed Sep 27 22:57:19 MDT 2006


On Wed, Sep 27, 2006 at 11:45:47AM -0600, Garrick Staples alleged:
> On Wed, Sep 27, 2006 at 12:21:48PM -0400, Ian Stakenvicius alleged:
> > Hi -- I've been using torque on gentoo linux for a while now, works great.
> > 
> > I'm sorting out a bug in the gentoo package installer, where directories are
> > removed when a package is upgraded.  The only way it seems gentoo can
> > prevent this is if  '.keep' files are added to various directories on
> > install.  This, however, causes an error when pbs_server starts, due to it
> > parsing the .keep file in server_priv/queues as a queue file.
> > 
> > I'm wondering if there are any current naming restrictions on queues (or
> > anything else); ie, is it normal for a queue to begin with the '.'
> > character?  And if this is unsupported already, would ppl be open to
> > patching pbsd_init so that it does not call que_recov() on files with '.' as
> > the first character?
> 
> That is reasonable since it wouldn't be a legal queue name.

I've added this to 2.1-fixes and trunk.

Index: src/server/pbsd_init.c
===================================================================
--- src/server/pbsd_init.c      (revision 1016)
+++ src/server/pbsd_init.c      (working copy)
@@ -1415,6 +1415,11 @@
   {
   struct stat sb;

+  if (*filename == '.')
+    {
+    return(-1);
+    }
+
   if (stat(filename,&sb) == -1)
     {
     return(errno);




More information about the torquedev mailing list