[Mauiusers] Should DPrint() always be followed by DBG?

[Josh Butikofer]

Brian is right--it doesn't have to always be prefixed with DBG. If there 
are any logging statements that are taking a lot of time, and they 
aren't wrapped in a high enough loglevel using DBG(), then it makes 
sense to increase their loglevel or add DBG() to them. This will cut 
down on the unnecessary slew of I/O writes and speed up the 
responsiveness of Maui.

--JB

Brian Christiansen wrote:
> Just as an added note, DBG() can be used as a conditional statement as 
> well. For example:
> 
> DBG(3,fSCHED)
> {
> DPrint("\n");
> }
> 
> So DPrint doesn't have to always be prefixed with DBG.
> 
> Brian
> 
> 
> Bas van der Vlies wrote:
>>
>> On 6 okt 2008, at 14:50, Michael Barnes wrote:
>>
>>> Hello,
>>>
>>> This is more towards developers.
>>>
>>> We are running Maui 3.2.6p13, so forgive me if this has been fixed in
>>> later versions or snapshots, but we ran into trouble when trying to
>>> schedule 20-25k jobs.
>>>
>>> We have patched Maui to handle 32k jobs up from its default 4k limit,
>>> and then we found that Maui was unresponsive due to almost 100% of its
>>> logging was from src/moab/MRes.c where it was executing these lines:
>>>
>>> ./src/moab/MRes.c: DPrint("INFO: R1[%d] S: %ld E: %ld T: %d N: %d\n",
>>> ./src/moab/MRes.c: DPrint("INFO: R2[%d] S: %ld E: %ld T: %d N: %d\n"
>>>
>>> We ripped out that code, recompiled, and now Maui is usable.
>>>
>>> After poking around, I found that almost all of the DPrint statements
>>> were prefixed with something like DBG(2,fUI). There are about 40 lines
>>> of code that have DPrint()s without DBG()s in front of them.
>>>
>>>
>>> Should all of the DPrint()s be prefixed with a DBG()?
>>>
>>
>> Michael,
>>
>> I find this a good suggestion. Just checked the latest snapshot and 
>> the DPrint statements did not changed.
>>
>> I am also interested what of kind you patches you applied to maui to 
>> handle this amount of jobs.
>>
>> Regards
>>
>> -- 
>> Bas van der Vlies
>> basv at sara.nl
>>
>>
>>
>> _______________________________________________
>> mauiusers mailing list
>> mauiusers at supercluster.org
>> http://www.supercluster.org/mailman/listinfo/mauiusers
> 
> _______________________________________________
> mauiusers mailing list
> mauiusers at supercluster.org
> http://www.supercluster.org/mailman/listinfo/mauiusers