[Mauiusers] Bug in MFSProcessOConfig?

Josh Butikofer josh at clusterresources.com
Wed Mar 28 14:14:26 MDT 2007


This patch has been applied and is available in the newly released patch 19.

-- 
Joshua Butikofer
Cluster Resources, Inc.

josh at clusterresources.com
Voice: (801) 717-3707
Fax:   (801) 717-3738
--------------------------


Åke Sandgren wrote:
> Hi!
> In MFSProcessOConfig there seems to be a bug in handling the FSPOLICY
> argument.
>     case pFSPolicy:
> 
>       if (strchr(SVal,'%'))
>         MSched.PercentBasedFS = TRUE;
> 
>       if (MUBoolFromString(SVal,FALSE) == TRUE)
>         {
>         /* enable backlevel support */
> 
>         F->FSPolicy = fspDPS;
>         }
>       else
>         {
>         F->FSPolicy = MUGetIndex(SVal,MFSPolicyType,FALSE,F->FSPolicy);
>         }
> 
> If SVal contains % the MUGetIndex will always fail as far as i can see,
> i.e. returning the Default.
> 
> Will this work? This of course assumes the the '%' is always at the end.
>     case pFSPolicy:
> 
>       if ((p = strchr(SVal,'%')) != NULL) {
>         MSched.PercentBasedFS = TRUE;
>         *p = '\0';
>       }
> 


More information about the mauiusers mailing list