[Mauiusers] maui not honoring multiple PBSPro node attributes

Franco M. Bladilo bladilo at rice.edu
Wed Mar 29 16:12:13 MST 2006


Jenett,
Thanks a bunch, the patch works perfectly, we run PBSPro 5.4.5 on x86_64 
here.
Can someone at clusteresources consider this patch for inclusion on p15?

Franco.
Jenett Tillotson wrote:

>
> We are also having problems with maui not seeing all the PBS nodes 
> properties.  We are using PBSPro 5.4.2.43350 and maui 3.2.6p14.  I 
> noticed that whenever I start maui, it sees all the node properties, 
> but on it's second scheduling iteration, it only sees one of the 
> properties.  I then found two different parts of the maui code which 
> parses the node information and both parse them differently.  So, I 
> went ahead and copied one method of parsing the property information 
> to the other section, rebuilt the code, and now maui sees all the 
> nodes properties.  Here's a patch I applied to the MPBSI.c file in the 
> src/moab directory of the maui-3.2.6p14 distribution:
>
> -------------------------------------------------------------------
> --- MPBSI.c.orig        2006-01-13 17:24:25.000000000 -0500
> +++ MPBSI.c     2006-03-27 09:05:12.000000000 -0500
> @@ -3359,19 +3359,20 @@
>        }
>      else if (!strcmp(AP->name,ATTR_NODE_properties))
>        {
> -      MUStrCpy(tmpBuffer,AP->value,sizeof(tmpBuffer));
> -
> -      memset(N->FBM,0,sizeof(N->FBM));
> +      if (R->U.PBS.PBS5IsEnabled == FALSE)
> +        {
> +        strcpy(tmpBuffer,AP->value);
>
>        ptr = MUStrTok(tmpBuffer,", \t",&TokPtr);
>
>        while (ptr != NULL)
>          {
> -        MUGetMAttr(eFeature,ptr,mAdd,N->FBM,sizeof(N->FBM));
> +          MNodeProcessFeature(N,ptr);
>
>          ptr = MUStrTok(NULL,", \t",&TokPtr);
> +          } /* END while (ptr != NULL) */
>          }
> -      }
> +      }   /* END else if (!strcmp()) */
>      else if (!strcmp(AP->name,ATTR_NODE_np))
>        {
>        /* set virtual processors */
> ---------------------------------------------------------
>
> Use this at your own risk!  My experience with the maui support team 
> is that everything is going into moab and if you want a REAL system, 
> you'll purchase moab.  Can't blame them for making a buck, but I 
> figured I'd just look into the maui source code to find these problems 
> and fix them myself.
>
> And note, I'm not a developer - I'm a system admin with some 
> programming skills.  So no comments about my patch file.  I do my best.
>
> Jenett
>


-- 
Franco Bladilo
Linux/HPCC Administrator
Research Computing Support Group
Rice University
bladilo at rice.edu



More information about the mauiusers mailing list