[gold-users] Bug: configure.ac patch

Michael Jennings mej at lbl.gov
Tue Oct 9 10:02:45 MDT 2012


On Tuesday, 09 October 2012, at 17:01:32 (+0200),
Jonas Juselius wrote:

> This is what the standard Rocks roll build system does, and I'm not
> going to fix that...

That's fine.  You don't have to.  But someone sure should.  :-)

The simple fact is that ROCKS is wrong here.  If you look at how
correct RPMs are built, they almost always do one of two things:
either "make install DESTDIR=$RPM_BUILD_ROOT" or "%makeinstall."  The
latter is a macro which expands to a resetting of ALL AUTOTOOLS PATHS,
not just $prefix.  And in cases like Gold where there are additional
relative paths, those need to be passed in as well by the spec file.

No offense, but the patches you sent are not correct.  The build
procedure you're using is what needs to change, not the code.  Since
Gold doesn't properly support DESTDIR (largely because it doesn't use
automake), your best bet here is to do something like:

%makeinstall LOG_DIR=$RPM_BUILD_ROOT%{_prefix}/log DOC_DIR=$RPM_BUILD_ROOT%{_docdir}

Michael

-- 
Michael Jennings <mej at lbl.gov>
Senior HPC Systems Engineer
High-Performance Computing Services
Lawrence Berkeley National Laboratory
Bldg 50B-3209E        W: 510-495-2687
MS 050B-3209          F: 510-486-8615


More information about the gold-users mailing list