Bug 64 – pbs_mom reports some cpuset creation messages as errors not debug

Bug 64 - pbs_mom reports some cpuset creation messages as errors not debug

Summary:

pbs_mom reports some cpuset creation messages as errors not debug

Status:	RESOLVED FIXED

Product:	TORQUE
Component:	pbs_mom
Version:	2.4.x
Platform:	Other Linux

Importance:	P5 enhancement
Assigned To:	Glen

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-06-25 00:53 MDT by Chris Samuel
Modified:	2010-06-25 08:54 MDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch to correctly log attempts to create a cpuset as debug messages. (505 bytes, patch) 2010-06-25 00:53 MDT, Chris Samuel	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Chris Samuel 2010-06-25 00:53:02 MDT

Created an attachment (id=34) [details]
Patch to correctly log attempts to create a cpuset as debug messages.

The function im_request() in src/resmom/mom_comm.c logs the message:

 pbs_mom: LOG_ERROR::im_request, about to create cpuset for job 55100.blah.

as an error rather than a debug message (as used in src/resmom/start_exec.c).

The fix is to replace:

 log_err(-1, id, log_buffer);

with:

 log_ext(-1, id, log_buffer, LOG_DEBUG);

(which is copied from the same message in start_exec.c).  I believe the same
bug affects trunk (and presumably 2.5.x and 3.0.0-alpha).

Comment 1 Ken Nielson 2010-06-25 08:54:11 MDT

Patch has been applied to 2.4-fixes, trunk and 3.0-alpha.