Bug 59 – The -m option for qdel rejects a message with an '=' sign

Bug 59 - The -m option for qdel rejects a message with an '=' sign

Summary:

The -m option for qdel rejects a message with an '=' sign

Status:	RESOLVED FIXED

Product:	TORQUE
Component:	clients
Version:	2.4.x
Platform:	Other Linux

Importance:	P5 enhancement
Assigned To:	Al Taufer

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-14 01:25 MDT by Chris Samuel
Modified:	2010-06-14 16:19 MDT (History)
CC List:	2 users (show)

See Also:

Attachments
Remove the check that the extended message in qdel doesn't contain '=' (488 bytes, patch) 2010-05-14 01:25 MDT, Chris Samuel	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Chris Samuel 2010-05-14 01:25:41 MDT

Created an attachment (id=32) [details]
Remove the check that the extended message in qdel doesn't contain  '='

Garrick pointed out on list that you cannot specify a message for qdel
with the -m option which includes an equals sign, there is a specific
check in qdel.c to reject such things.

There appears to be no reason for the check as the message is fed into
sendmail via a pipe once it is already running so there appears to be
no opportunity for misuse.

The attached patch (against 2.4 fixes) removes the check.

Comment 1 Al Taufer 2010-06-14 16:19:11 MDT

Patch applied to 2.4-fixes, trunk, and 3.0-alpha branches.