Bug 30 – process_Dreply leaks memory

Bug 30 - process_Dreply leaks memory

Summary:

process_Dreply leaks memory

Status:	REOPENED

Product:	TORQUE
Component:	pbs_server
Version:	2.3.x
Platform:	All All

Importance:	P5 normal
Assigned To:	Ken Nielson

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-22 13:59 MDT by Ken Nielson
Modified:	2009-12-29 15:48 MST (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Ken Nielson 2009-09-22 13:59:22 MDT

Each call to process_Dreply leaks a few bytes of memory

Comment 1 Ken Nielson 2009-09-22 14:11:53 MDT

revision 3126. Fixed in 2.3-fixes

Comment 2 Glen 2009-10-15 22:38:58 MDT

looks like this fix was backed out because it can cause a double free.

Do you know where else it was free'd?  what if instead of just freeing it you
also set the pointer to NULL.  If we check for NULL before any attempt to free
this memory, then we should avoid a double free.

Comment 3 Ken Nielson 2009-10-16 08:35:28 MDT

The original fix that was backed out set the pointer to NULL after the free but
it appears the memory is freed in other functions as well. We might want to
check all free operations and set pointers to NULL if appropriate.

Comment 4 Josh Butikofer 2009-12-29 15:08:31 MST

This is a test to see if Bugzilla is now sending e-mail to torquedev.

Comment 5 Josh Butikofer 2009-12-29 15:15:20 MST

This is another test.

Comment 6 Glen 2009-12-29 15:48:48 MST

adding torquedev to the CC list for the bug