Bug 158 - [2.5.8] suse.pbs_mom uses never touched file /var/lock/subsys/pbs_mom
: [2.5.8] suse.pbs_mom uses never touched file /var/lock/subsys/pbs_mom
Status: NEW
Product: TORQUE
pbs_mom
: 2.5.x
: PC Linux
: P5 enhancement
Assigned To: Ken Nielson
:
:
:
  Show dependency treegraph
 
Reported: 2011-09-04 15:39 MDT by Tobias Burnus
Modified: 2011-09-04 15:58 MDT (History)
1 user (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Tobias Burnus 2011-09-04 15:39:41 MDT
On SUSE Linux, the directory /var/lock/subsys/ does not exist, the file is
never touched (contrary to contrib/init.d/pbs_mom) and I get the following
rpmlint warning:

  torque-mom.x86_64: W: subsys-unsupported /etc/init.d/pbs_mom
  The init script uses /var/lock/subsys which is not supported by this
  distribution.

I think the following patch should be correct:

--- contrib/init.d/suse.pbs_mom.orig   2011-09-04 23:36:11.000000000 +0200
+++ contrib/init.d/suse.pbs_mom        2011-09-04 23:36:16.000000000 +0200
@@ -47,7 +47,7 @@
                rc_status -v
                ;;
        purge)
-               [ -f /var/lock/subsys/pbs_mom ] && $0 stop
+               checkproc -p $PIDFILE $PBS_DAEMON && $0 stop
                echo -n "Starting TORQUE Mom with purge: "
                startproc $PBS_DAEMON -r $DAEMON_ARGS
                rc_status -v
Comment 1 Tobias Burnus 2011-09-04 15:58:33 MDT
While patching files, could you also apply the following patch, which silences
the warning:

torque.x86_64: W: incorrect-fsf-address
/usr/share/doc/packages/torque/contrib/pbstop
The Free Software Foundation address in this file seems to be outdated or
misspelled.

--- contrib/pbstop.orig 2011-09-04 23:52:58.000000000 +0200
+++ contrib/pbstop      2011-09-04 23:56:22.000000000 +0200
@@ -14,7 +14,7 @@
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program; if not, write to the Free Software
-#  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+#  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301,
USA.
 #
 #  Latest version of this software may be found at:
 #      http://www-rcf.usc.edu/~garrick/perl-PBS